develooper Front page | perl.perl5.porters | Postings from February 2008

Re: Prob in CPAN make/gen & test...multiple mods appear affected.

Thread Previous | Thread Next
From:
Linda W
Date:
February 27, 2008 09:02
Subject:
Re: Prob in CPAN make/gen & test...multiple mods appear affected.
Message ID:
47C55EDF.9060508@tlinx.org
Robin Barker wrote:
> 
> From: Linda W [mailto:perl-diddler@tlinx.org]
> --- lib/ExtUtils/Install.pm     2007-09-09 16:17:23.000000000 -0700
> +++ lib/ExtUtils/Install.pm     2008-02-27 03:39:18.110625000 -0800
> @@ -436,7 +436,8 @@
>       my $path='';
>       my @make;
>       while (@dirs) {
> -        $dir = File::Spec->catdir($vol,@dirs);
> +        $dir = File::Spec->catdir(@dirs);
> +        $dir = File::Spec->catpath($vol,$dirs) if length $vol; 
>           next if ( $dir eq $path );
>           if ( ! -e $dir ) {
>               unshift @make,$dir;
> End of patch
> 
> The C<$dirs> in the second added line looks like a typo;
> I think it should be C<$dir> (or possibly C<@dirs>).
> 
----
	Right.  After I installed and checked it, when I went
back to look, it pulled out a fresh copy of the source, and I retyped
what I had entered...(and added an 's' after 2nd $dir in line)...
thanks for pointing that out.  It was a bit of an odd hour for me to be
trying patches..:-)

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About