develooper Front page | perl.perl5.porters | Postings from February 2008

Re: Assistance with IPC modules and perl 5.10

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
February 23, 2008 09:48
Subject:
Re: Assistance with IPC modules and perl 5.10
Message ID:
20080223174434.GQ38653@plum.flirble.org
On Fri, Feb 15, 2008 at 06:44:09PM -0500, Tom Callaway wrote:

> You can see the build log (and test failures) for IPC::ShareLite here:
> http://koji.fedoraproject.org/koji/getfile?taskID=424041&name=build.log
> 
> (note that IPC::ShareLite is patched with
> http://rt.cpan.org/Public/Bug/Display.html?id=17663, normally it just
> segfaults during the tests instead of failing)

I see

+ echo 'Patch #0 (IPC-ShareLite-0.09-64bit.patch):'
Patch #0 (IPC-ShareLite-0.09-64bit.patch):
+ patch -p1 -s
+ echo 'Patch #1 (IPC-ShareLite-0.09-string.patch):'
Patch #1 (IPC-ShareLite-0.09-string.patch):

Not knowing where the SRPMs are, I'm guessing that the first is the patch in
#17663, but what is the second?

> Also, the build log and test failures for IPC::SharedCache are here:
> http://koji.fedoraproject.org/koji/getfile?taskID=424236&name=build.log

This is strange. Andreas seems to be able to get a failure on an unpatched
0.09, which is different from yours, but I can't replicate it:

http://www.nntp.perl.org/group/perl.cpan.testers/2008/01/msg997450.html

His automated smoker gets:

PERL_DL_NONLAZY=1 /home/src/perl/repoperls/installed-perls/perl/pc9yqQU/perl-5.10.0@33081/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl
1..8
ok 1
not ok 2
Can't call method "store" on an undefined value at test.pl line 33.

versus your log:

PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl
1..8
ok 1
ok 2
ok 3
not ok 4
ok 5
ok 6
not ok 7
not ok 8
+ exit 0

Moreover, your log shows this:

ShareLite.c: In function 'XS_IPC__ShareLite_read_share':
ShareLite.xs:338: warning: 'length' is used uninitialized in this function
ShareLite.xs:336: note: 'length' was declared here
ShareLite.xs:339: warning: 'data' is used uninitialized in this function
ShareLite.xs:335: note: 'data' was declared here

Which seems very very wrong, but I can't get a C compiler to scream about that.
Does running your build under valgrind show anything interesting?

On Sat, Feb 23, 2008 at 06:37:54AM -0500, Tom spot Callaway wrote:

> > Does the appended fix it?
> 
> Sadly, no, it does not change the test failures.

Gah. However, I suspect that it (ultimately) is also needed, if sv_usepvn is
still used. (Alex's patch in 17663 removes the use of sv_usepvn)

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About