[PATCH ext/Devel/DProf] ... and the rest; was RE: unnecessary define

> On Wed, Jan 23, 2008 at 02:13:30PM -0000, Robin Barker wrote:

> > > Do we actually need -DPERLDBf_NONAME and -DPERLDBf_GOTO either?

> > 

> > I guess not.  New patch attached.

>

> Thanks applied (change 33056)

>

> Nicholas Clark



We don't need the other define in ext/Devel/DProf/Makefile.PL :

all PL_NEEDED does is cause another macro to be defined,

and that second macro (defstash) is not used, and has not

been used since 1999!



Robin



diff -ur ../perl-current/ext/Devel/DProf/DProf.xs ext/Devel/DProf/DProf.xs

--- ../perl-current/ext/Devel/DProf/DProf.xs

+++ ext/Devel/DProf/DProf.xs	2008-01-23 19:11:20.000000000 +0000

@@ -466,10 +466,6 @@

     }

 }

 

-#ifdef PL_NEEDED

-#  define defstash PL_defstash

-#endif

-

 /* Counts overhead of prof_mark and extra XS call. */

 static void

 test_time(pTHX_ clock_t *r, clock_t *u, clock_t *s)

diff -ur ./perl-current/ext/Devel/DProf/Makefile.PL ext/Devel/DProf/Makefile.PL

--- ../perl-current/ext/Devel/DProf/Makefile.PL	2008-01-23 15:06:22.000000000 +0000

+++ ext/Devel/DProf/Makefile.PL

@@ -10,7 +10,6 @@

 	VERSION_FROM	=> 'DProf.pm',

 	clean		=> { 'FILES' => 'tmon.out t/tmon.out t/err'},

 	XSPROTOARG	=> '-noprototypes',

-	DEFINE		=> '-DPL_NEEDED',

 	dist		=> {

 			     COMPRESS => 'gzip -9f',

 			     SUFFIX => 'gz',





-------------------------------------------------------------------

This e-mail and any attachments may contain confidential and/or

privileged material; it is for the intended addressee(s) only.

If you are not a named addressee, you must not use, retain or

disclose such information.



NPL Management Ltd cannot guarantee that the e-mail or any

attachments are free from viruses.



NPL Management Ltd. Registered in England and Wales. No: 2937881

Registered Office: Serco House, 16 Bartley Wood Business Park,

                   Hook, Hampshire, United Kingdom  RG27 9UY

-------------------------------------------------------------------

• [PATCH ext/Devel/DProf] ... and the rest; was RE: unnecessary define by Robin Barker
• Re: [PATCH ext/Devel/DProf] ... and the rest; was RE: unnecessary define by Nicholas Clark