develooper Front page | perl.perl5.porters | Postings from January 2008

[PATCH ext/Devel/DProf/Makefile.PL] unnecessary define

Thread Next
Robin Barker
January 23, 2008 05:57
[PATCH ext/Devel/DProf/Makefile.PL] unnecessary define
Message ID:
I don't really understand why Devel::DProf Makefile needed to 

define G_NODEBUG; but now the definition conflicts with cop.h.

I removed the -DG_NODEBUG=32 from ext/Devel/DProf/Makefile.PL 

and the redefinition warning went away, and all tested passed.

The patch attached/below removes -DG_NODEBUG=32 and reformat 

the other DEFINEs.

Robin Barker

diff -ur ../perl-current/ext/Devel/DProf/Makefile.PL ./ext/Devel/DProf/Makefile.PL

--- ../perl-current/ext/Devel/DProf/Makefile.PL	2006-06-13 20:29:01.000000000 +0100

+++ ./ext/Devel/DProf/Makefile.PL

@@ -10,8 +10,11 @@


 	clean		=> { 'FILES' => 'tmon.out t/tmon.out t/err'},

 	XSPROTOARG	=> '-noprototypes',


-			  .'-DG_NODEBUG=32 -DPL_NEEDED',

+	DEFINE		=> join(' ', qw(

+				-DPERLDBf_NONAME=0x40 

+				-DPERLDBf_GOTO=0x80

+			  	-DPL_NEEDED

+			    )),

 	dist		=> {

 			     COMPRESS => 'gzip -9f',

 			     SUFFIX => 'gz',

End of patch



This e-mail and any attachments may contain confidential and/or

privileged material; it is for the intended addressee(s) only.

If you are not a named addressee, you must not use, retain or

disclose such information.

NPL Management Ltd cannot guarantee that the e-mail or any

attachments are free from viruses.

NPL Management Ltd. Registered in England and Wales. No: 2937881

Registered Office: Serco House, 16 Bartley Wood Business Park,

                   Hook, Hampshire, United Kingdom  RG27 9UY


Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About