develooper Front page | perl.perl5.porters | Postings from January 2008

Re: Change 32881: Make Data::Dumper handle blessed regexes properly, bump version as well. This may not be entirely correct on older perls, needs further investigation.

Thread Previous
From:
Jerry D. Hedden
Date:
January 7, 2008 09:19
Subject:
Re: Change 32881: Make Data::Dumper handle blessed regexes properly, bump version as well. This may not be entirely correct on older perls, needs further investigation.
Message ID:
1ff86f510801070919r12018fd6l1126c7df6b230631@mail.gmail.com
> Change 32881 by demerphq@demerphq-gemini on 2008/01/06 20:34:41
>
>         Make Data::Dumper handle blessed regexes properly, bump version as well. This may not be entirely correct on older perls, needs further investigation.
>
> Affected files ...
>
> ... //depot/perl/ext/Data/Dumper/Dumper.pm#50 edit
> ... //depot/perl/ext/Data/Dumper/Dumper.xs#73 edit
> ... //depot/perl/ext/Data/Dumper/t/bless.t#3 edit

Jerry D. Hedden wrote:
> This is failing under blead:
>
> perl-current > ./perl.exe -Ilib ext/Data/Dumper/t/bless.t
> 1..11
> ok 1 - use Data::Dumper;
> ok 2 - package name in bless is escaped if needed
> ok 3 - eval reverts dump
> ok 4 - package name in bless is escaped if needed
> ok 5 - eval reverts dump
> ok 6 - We can dump blessed qr//'s properly
> ok 7 - package name in bless is escaped if needed
> ok 8 - eval reverts dump
> ok 9 - package name in bless is escaped if needed
> ok 10 - eval reverts dump
> Undefined subroutine &re::regexp_pattern called at lib/Data/Dumper.pm line 373.
> # Looks like you planned 11 tests but only ran 10.
> # Looks like your test died just after 10.

I found the cause.  're' is an XS modules.  However, in Makefile.SH
ext/re/re.pm is unconditionally copied to lib even if Perl is configured
with '-Dnoextensions="... re ..."

So, the question is:  Should the above copy be conditional if 're' is not
configured, or does re.pm need to be conditionalized for its XS code?

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About