develooper Front page | perl.perl5.porters | Postings from January 2008

RE: [PATCH pp_ctl.c] unnecessary cast

Thread Previous
From:
Robin Barker
Date:
January 7, 2008 02:40
Subject:
RE: [PATCH pp_ctl.c] unnecessary cast
Message ID:
46A0F33545E63740BC7563DE59CA9C6D0939AD@exchsvr2.npl.ad.local
 >  This line warns (signed v. unsigned) 



 >         if (!re || !RX_PRECOMP(re) || RX_PRELEN(re) != (I32)len || 



 > As far as I can see, both C<RX_PRELEN> and C<len> of type are STRLEN, so no cast is needed. 



 >  Robin Barker 



Someone (Nicolas) got their first, see patch   <http://public.activestate.com/cgi-bin/perlbrowse/p/32862> 32862 



 Robin





-------------------------------------------------------------------

This e-mail and any attachments may contain confidential and/or

privileged material; it is for the intended addressee(s) only.

If you are not a named addressee, you must not use, retain or

disclose such information.



NPL Management Ltd cannot guarantee that the e-mail or any

attachments are free from viruses.



NPL Management Ltd. Registered in England and Wales. No: 2937881

Registered Office: Serco House, 16 Bartley Wood Business Park,

                   Hook, Hampshire, United Kingdom  RG27 9UY

-------------------------------------------------------------------

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About