develooper Front page | perl.perl5.porters | Postings from October 2007

Re: [PATCH] New failing test for RT#45667 (m/[#]/x treated inconsistently)

Thread Previous | Thread Next
From:
Rafael Garcia-Suarez
Date:
October 30, 2007 05:53
Subject:
Re: [PATCH] New failing test for RT#45667 (m/[#]/x treated inconsistently)
Message ID:
b77c1dce0710300553w7b948810t774024c00c8789ec@mail.gmail.com
On 28/10/2007, Chris Dolan <chris@chrisdolan.net> wrote:
> Hello,
>
> RT#45667 points out that the Perl parser and the Regexp parser treat
> m/[#]/x differently.  The former treats the # as a comment character
> and the latter treats it as a literal.  I propose that we adopt the
> Perl parser's behavior because 1) doing otherwise would require us to
> add more regexp-specific knowledge to the Perl parser and 2) other
> Regexp engines may not want to treat [#] the same as the current
> default engine.
>
> The patch below adds a (currently failing) test to the regexp parser
> to enforce this decision.  The patch is against rsync 5.10.0.32199

it doesn't seem that op/regexp.t supports TODO tests. That would
probably be a worthwhile addition...

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About