Re: [PATCH] Cleanup of the regexp API

On 4/24/07, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> On 4/23/07, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> > A cleanup patch for the public regexp API & docs.
>
> dmq reported a warning and error on VC7, the warning was a mismatch
> between an argument name in proto/declaration (fixed in the attached).
> The error results from "(*package)" in the callback struct expanding
> to to Perl_package due to C<#define package Perl_package> in embed.h
> resulting in a:
>
>
> \pp_hot.c(1182) : error C2039: 'Perl_package' : is not a member of
> 'regexp_engine
>
> Since we've both gone to sleep the fix for that will have to wait.

IMO we should probably just rename it re_package or something. (Not on
my computer so i havnt looked at the patch yet so maybe you already
did that :-))

yves

-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

• [PATCH] Cleanup of the regexp API by Ævar Arnfjörð Bjarmason
• Re: [PATCH] Cleanup of the regexp API by Ævar Arnfjörð Bjarmason
• Re: [PATCH] Cleanup of the regexp API by Rafael Garcia-Suarez
• Re: [PATCH] Cleanup of the regexp API by Ævar Arnfjörð Bjarmason
• Re: [PATCH] Cleanup of the regexp API by demerphq