Front page | perl.perl5.porters |
Postings from April 2007
On Thu, Feb 08, 2007 at 09:38:15PM +0100, Andreas J. Koenig wrote: > >>>>> On Thu, 8 Feb 2007 09:54:49 -0800 (PST), "Jerry D. Hedden" <jdhedden@yahoo.com> said: > I looked into the Text-Balanced-2 package on CPAN and compared it with > maintperl@30176: > > % md5sum lib/Text/Balanced.pm /home/src/perl/repoperls/perl-m-5.8.0@30176/lib/Text/Balanced.pm > b174404a8b7391f7643e2d04673c7def lib/Text/Balanced.pm > 8abb7ef7e80687bfbe37215ea23ad975 /home/src/perl/repoperls/perl-m-5.8.0@30176/lib/Text/Balanced.pm > > > So they are not the same. This is true > No, it is wrong. You should never change a module without changing its > version. Your patch says: > > -$VERSION = 2.000000; > +$VERSION = '2.000000'; > > But seriously, it should be > > -$VERSION = 2.000000; > +$VERSION = '2.000001'; > > or whatever. Let it reflect that it is a *different* version. It is functionally identical but a different implementation. I don't want it to be visible as an "upgrade" > I do agree that the old rule to quote version strings should be kept > up, at least for a while until version.pm has become as widespread as > it deserves. I am loathe to pull in an entirely new dependency into maint, for 1 line of one module, especially as that line isn't actually an executed line. In particular, pulling it in at this time effectively fossilises the API *and* the implementation, when it seems that neither are quite stable. (The whole thing about action at a distance with UNIVERSAL::VERSION) I don't have a good answer. One option is to revert to 1.97, which IIRC is the last version that didn't use a version object. Nicholas Clark