Front page | perl.perl5.porters |
Postings from March 2007
Re: [PATCH] p55 tests
Thread Previous
|
Thread Next
From:
Dave Mitchell
Date:
March 26, 2007 14:50
Subject:
Re: [PATCH] p55 tests
Message ID:
20070326215137.GH5473@iabyn.com
On Thu, Mar 22, 2007 at 06:40:56PM +0100, Gerard Goossen wrote:
> On Thu, Mar 22, 2007 at 12:41:37AM +0000, Dave Mitchell wrote:
> > On Tue, Mar 20, 2007 at 07:14:18PM +0100, Gerard Goossen wrote:
> > > This patch adds a test for p55, the "Perl 5 to Perl 5" translator.
> > >
> > > The patch is a bit large, because I made 'nomad' into a package
> > > 'Nomad.pm', but I don't think I changed anything to its internals.
> > > Important part is the mad/t/p55.t other changes are moving things or
> > > helper routines.
> >
> > Can I suggest that you submit this is two separate patches. First,
> > where you strictly just cut-paste the body of mad/nomad to Nomad.pm,
> > with no changes. Then in a second patch, include any fixups to Noamd.pm
> > plus the other changes. That way it's easier for people reviewing
> > history to see and understand any changes.
> >
> >
> > Also, when adding new files, you should also patch MANIFEST.
>
>
> These two patches replace the previous patch.
> The first one should also include a 'mv mad/nomad mad/Nomad.pm'
> And it is a lot more readable :)
Thanks, applied as changes #30767, #30768
--
"You may not work around any technical limitations in the software"
-- Windows Vista license
Thread Previous
|
Thread Next