Re: [PATCH] MAD disable constant inlining

On Wed, Mar 21, 2007 at 07:42:08PM +0100, Gerard Goossen wrote:
> The p55 translator replaced constants subs call with their values.
> The patch disable constants inling when MAD is enabled. 

> -#endif
> +#else
>  			    goto its_constant;
> +#endif
>  			}
>  		    }
>  #ifdef PERL_MAD
> @@ -5450,6 +5451,7 @@ Perl_yylex(pTHX)
>  			Perl_warner(aTHX_ packWARN(WARN_AMBIGUOUS),
>  				"Ambiguous use of -%s resolved as -&%s()",
>  				PL_tokenbuf, PL_tokenbuf);
> +#ifndef PERL_MAD
>  		    /* Check for a constant sub */
>  		    if ((sv = gv_const_sv(gv))) {
>  		  its_constant:
> @@ -5458,6 +5460,7 @@ Perl_yylex(pTHX)
>  			yylval.opval->op_private = 0;
>  			TOKEN(WORD);
>  		    }
> +#endif

Shouldn't these changes be conditional on PL_madskills instead?

I think as is, if you compile with PERL_MAD you're going to disable
inlining come what may, whereas I thought that the intent of PL_madskills
was that the "normal" behaviour (no PERL_MAD) was still the default, just
now runtime switchable to storing all the madprops data.

Nicholas Clark

• [PATCH] MAD disable constant inlining by Gerard Goossen
• Re: [PATCH] MAD disable constant inlining by Nicholas Clark
• Re: [PATCH] MAD disable constant inlining by Gerard Goossen
• Re: [PATCH] MAD disable constant inlining by Rafael Garcia-Suarez
• Re: [PATCH] MAD disable constant inlining by Gerard Goossen