Front page | perl.perl5.porters |
Postings from March 2007
Re: Change 28550: [PATCH] z/OS: t/ - mostly EBCDIC fixes
Thread Next
From:
Nicholas Clark
Date:
March 21, 2007 10:32
Subject:
Re: Change 28550: [PATCH] z/OS: t/ - mostly EBCDIC fixes
Message ID:
20070321173146.GS6221@plum.flirble.org
On Wed, Jul 12, 2006 at 12:00:04AM -0700, H. Merijn Brand wrote:
> ==== //depot/perl/t/op/pack.t#111 (xtext) ====
> Index: perl/t/op/pack.t
> --- perl/t/op/pack.t#110~25249~ 2005-07-31 23:57:09.000000000 -0700
> +++ perl/t/op/pack.t 2006-07-11 23:53:22.000000000 -0700
> @@ -1531,10 +1535,15 @@
> {
> # counted length prefixes shouldn't change C0/U0 mode
> # (note the length is actually 0 in this test)
> - is(join(',', unpack("aC/UU", "b\0\341\277\274")), 'b,8188');
> - is(join(',', unpack("aC/CU", "b\0\341\277\274")), 'b,8188');
> - is(join(',', unpack("aU0C/UU", "b\0\341\277\274")), 'b,225');
> - is(join(',', unpack("aU0C/CU", "b\0\341\277\274")), 'b,225');
> + if (ord('A') == 193) {
> + is(join(',', unpack("aU0C/UU", "b\0\341\277\274")), 'b,0');
> + is(join(',', unpack("aU0C/CU", "b\0\341\277\274")), 'b,0');
> + } else {
> + is(join(',', unpack("aC/UU", "b\0\341\277\274")), 'b,8188');
> + is(join(',', unpack("aC/CU", "b\0\341\277\274")), 'b,8188');
> + is(join(',', unpack("aU0C/UU", "b\0\341\277\274")), 'b,225');
> + is(join(',', unpack("aU0C/CU", "b\0\341\277\274")), 'b,225');
> + }
> }
>
> {
>
Mmm, does not add up. 2 for EBCDIC, 4 for everyone else.
Presumably you did the merge of their patch blind, and IBM has no budget to
actually test any of this. :-(
Nicholas Clark
Thread Next
-
Re: Change 28550: [PATCH] z/OS: t/ - mostly EBCDIC fixes
by Nicholas Clark