RE: [PATCH] Compress::Raw::Zlib doesn't need ppport.h in core

From: Jerry D. Hedden [mailto:jdhedden@yahoo.com]
 
> The attached patch conditionalizes the inclusion of ppport.h in
> Compress/Raw/Zlib.xs so that it doesn't need ppport.h in core.

Hi Jerry

The patch certainly makes the inclusion of pport.h only happen when built
away from the core. Unfortunately I was already using the DEFINE option with
WriteMakefile.

This is the relevant part of Makefile.PL after your patch

WriteMakefile( 
    NAME         => 'Compress::Raw::Zlib',
    VERSION_FROM => 'lib/Compress/Raw/Zlib.pm',
    INC          => "-I$ZLIB_INCLUDE" ,
    DEFINE       => "$OLD_ZLIB $WALL -DGZIP_OS_CODE=$GZIP_OS_CODE" ,
    ...
    (
      $ENV{PERL_CORE}
        ? ()
        : ('DEFINE' => '-DUSE_PPPORT_H')
    ),
    ...

Can you rework your patch to fix this please?

Paul

• [PATCH] Compress::Raw::Zlib doesn't need ppport.h in core by Jerry D. Hedden
• RE: [PATCH] Compress::Raw::Zlib doesn't need ppport.h in core by Paul Marquess
• [PATCH] Compress::Raw::Zlib doesn't need ppport.h in core [REVISED] by Jerry D. Hedden
• RE: [PATCH] Compress::Raw::Zlib doesn't need ppport.h in core [REVISED] by Paul Marquess
• Re: [PATCH] Compress::Raw::Zlib doesn't need ppport.h in core [REVISED] by Rafael Garcia-Suarez