Front page | perl.perl5.porters |
Postings from February 2007
Re: refactor dump.c
Thread Previous
From:
Jim Cromie
Date:
February 28, 2007 20:10
Subject:
Re: refactor dump.c
Message ID:
45E65234.6020507@gmail.com
Steve Peters wrote:
>
> For this, I'd really prefer to see one function declaration rather than
> two. I think instead that the code should be #ifndef'd inside the functions
> rather than #ifndef'ing the whole thing. I have two reasons for it. First,
> its less code. Second, its less error prone. Someone will change one but
> not the other.
>
>
heres an incremental patch to do the above.
Its been a while since I did a -Dmad build (in Nov I think),
IIRC it failed a few tests. I'll try one on this latest patchset soon.
thanks
jimc
Thread Previous