Front page | perl.perl5.porters |
Postings from February 2007
>>>>> On Thu, 8 Feb 2007 09:54:49 -0800 (PST), "Jerry D. Hedden" <jdhedden@yahoo.com> said: > Jerry D. Hedden wrote: >> The problem with this is that after building and installing >> 5.8.x@30165, and then running 'r' from the CPAN prompt, you >> get: >> >> Package namespace installed latest in CPAN file >> ... >> Text::Balanced 2 2.000000 >> DCONWAY/Text-Balanced-v2.0.0.tar.gz >> ... >> >> This is no good. It show there that an update is needed >> when there shouldn't be. My patch (which quotes the >> 2.000000) fixes this so that the above does not show up. > John Peacock wrote: >> I get that part, but I'm wondering why it isn't *CPAN* >> that needs fixing, since those two $VERSION's are >> equivalent. > I'll submit a bug report against CPAN. I looked into the Text-Balanced-2 package on CPAN and compared it with maintperl@30176: % md5sum lib/Text/Balanced.pm /home/src/perl/repoperls/perl-m-5.8.0@30176/lib/Text/Balanced.pm b174404a8b7391f7643e2d04673c7def lib/Text/Balanced.pm 8abb7ef7e80687bfbe37215ea23ad975 /home/src/perl/repoperls/perl-m-5.8.0@30176/lib/Text/Balanced.pm So they are not the same. >> It can also be argued that perlmaint *does* need updating, >> since it doesn't have the XS version installed, but that's >> a different horse... > Okay. So there's no disagreement that my patch should be > applied to maint, correct? No, it is wrong. You should never change a module without changing its version. Your patch says: -$VERSION = 2.000000; +$VERSION = '2.000000'; But seriously, it should be -$VERSION = 2.000000; +$VERSION = '2.000001'; or whatever. Let it reflect that it is a *different* version. I do agree that the old rule to quote version strings should be kept up, at least for a while until version.pm has become as widespread as it deserves. -- andreasThread Previous | Thread Next