Front page | perl.perl5.porters |
Postings from February 2007
On 07/02/07, Nicholas Clark <nick@ccl4.org> wrote:
> I think I'd argue that its C is buggy:
>
> /* drop-through if not an object or method not found */
> switch SvTYPE(SvRV(root)) {
>
>
> but really also our macros should be wrapped in () to avoid (other)
> precedence issues. Currently we have
>
> #define SvTYPE(sv) (svtype)((sv)->sv_flags & SVTYPEMASK)
>
> (also in blead) which really should be
>
> #define SvTYPE(sv) ((svtype)((sv)->sv_flags & SVTYPEMASK))
>
> With that change to sv.h it passes all tests for me.
I just applied that to blead. (#30153)
Thread Previous
|
Thread Next