develooper Front page | perl.perl5.porters | Postings from January 2007

Re: New release ?

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
January 7, 2007 23:35
Subject:
Re: New release ?
Message ID:
20070108083543.27d0f178@pc09
On Mon, 8 Jan 2007 00:49:11 +0100, Marcus Holland-Moritz <mhx-perl@gmx.net>
wrote:

> On 2007-01-05, at 20:07:09 +0100, H.Merijn Brand wrote:
> 
> >   - initial value of NV_PRESERVES_UV_BITS
> > 
> > As long as no-one explicitly tells me to alter the behaviour regarding
> > the second item, I will take no action.
> 
> Currently, the default (/initial) value of NV_PRESERVES_UV_BITS
> is literal 'undef', which causes compilation failure of sv.c,
> despite Configure finishing successfully. So it's hard to make
> it worse in this case by changing the default.

What a superb summary. Not only me, but also the summarizer would greatly
appreciate if complex threads would be summarized this powerful!

Thanks, applied as change #29715

> As Nicholas pointed out, zero would be a much better default:
> 
> > > b) Let Configure choose a safe minimum for nv_preserves_uv_bits
> > >    and warn the user. Probably something like (4*$nvsize) or,
> > >    to be perfectly safe, zero like in uconfig.h.  
> > 
> > I'd go for 0. It generates valid C code, and I think that it's also
> > semantically correct.
> 
> The test failures that were caused by setting NV_PRESERVES_UV_BITS
> to zero should have been fixed by Sadahiro's patch, which has just
> been applied (change #29693).
> 
> So, I'd vote for fixing this. I had already suggested this change:
> 
> --- Configure.orig      2007-01-02 11:11:59.000000000 +0100
> +++ Configure   2007-01-02 19:18:48.000000000 +0100
> @@ -15322,7 +15322,7 @@
>  [1-9]*)        $echo "Your NVs can preserve only $nv_preserves_uv_bits bits of your UVs."  2>&1
>         d_nv_preserves_uv="$undef" ;;
>  *)     $echo "Can't figure out how many bits your NVs preserve." 2>&1
> -       nv_preserves_uv_bits="$undef" ;;
> +       nv_preserves_uv_bits="0" ;;
>  esac
>  
>  $rm -f try.* try
> 
> Marcus
> 


-- 
H.Merijn Brand         Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.9.x   on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.0 & 10.1, AIX 4.3 & 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/            http://www.test-smoke.org
                        http://www.goldmark.org/jeff/stupid-disclaimers/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About