develooper Front page | perl.perl5.porters | Postings from April 2006

Re: [PATCH] Removing another context parm

Thread Previous | Thread Next
From:
Craig A. Berry
Date:
April 29, 2006 09:03
Subject:
Re: [PATCH] Removing another context parm
Message ID:
craigberry-D9A220.11031429042006@x6.develooper.com
In article <20060427153156.GA11445@petdance.com>,
 andy@petdance.com ((Andy Lester)) wrote:

> -S_check_type_and_open(pTHX_ const char *name, const char *mode)
> +S_check_type_and_open(const char *name, const char *mode)

This breaks threaded builds on VMS because thread context is in fact 
used in a home-grown stat routine (see snippet of listing below).  I'm 
not sure what sort of patch to propose since I don't really understand 
the purpose of removing the pTHX_ just because it's not currently used 
on one or more platforms.  Surely the cost of one pointer on the stack 
is negligible compared to the added complexity of having thread context 
sometimes available and sometimes not.


       67810 S_check_type_and_open(const char *name, const char *mode)
   1   67811 {
   1   67812     Stat_t st;
    E            struct mystat
   1   67813     const int st_rc = PerlLIO_stat(name, &st);
             ......................1
%CC-E-UNDECLARED, (1) In the initializer for st_rc, "my_perl" is not 
declared.

    E                              Perl_flex_stat(my_perl, (name),( &st))
   1   67814

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About