develooper Front page | perl.perl5.porters | Postings from March 2006

Re: Change 23471: [PATCH blead] [perl #3038] Re: $qr = qr/^a$/m; $x =~ $qr; fails

From:
Nicholas Clark
Date:
March 25, 2006 07:18
Subject:
Re: Change 23471: [PATCH blead] [perl #3038] Re: $qr = qr/^a$/m; $x =~ $qr; fails
Message ID:
20060325151817.GS32132@plum.flirble.org
On Thu, Dec 02, 2004 at 01:20:28PM -0500, Rick Delaney wrote:
> On Wed, Dec 01, 2004 at 03:40:44PM +0000, Nicholas Clark wrote:
> > This patch:
> > 
> > On Thu, Nov 04, 2004 at 02:59:25AM -0800, Rafael Garcia-Suarez wrote:

> These two files should be left alone:
> > > ... //depot/perl/pp.c#427 edit
> > > ... //depot/perl/pp_hot.c#361 edit

> Look for the ****:
> 
> ==== //depot/perl/regexec.c#325 (text) ====
> 
> @@ -403,6 +403,7 @@
>      I32 ml_anch;
>      register char *other_last = Nullch;    /* other substr checked
> before this */
>      char *check_at = Nullch;       /* check substr found at this pos */
> +    I32 multiline = prog->reganch & PMf_MULTILINE;
> 
> **** above should be something like
> +    I32 multiline = PL_multiline | (prog->reganch & PMf_MULTILINE);

> +    I32 multiline = prog->reganch & PMf_MULTILINE;
> 
> **** above should be something like
> +    I32 multiline = PL_multiline | (prog->reganch & PMf_MULTILINE);

> **** The following changes in this file would not be suitable for maint:

> > I presume that the conflicts are due to the removal of $* from blead:
> 
> Yep.  
> 
> I think that should do it; the new tests should tell you.

Yes, bang on.

Sorry that it's taken so long (and a really big tuit) to make the time to do
this. (It never got started because I feared that it might not be, and I might
get bogged down for ages trying to work it out, delaying whatever other
merging I was trying to get finished)

Nicholas Clark



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About