develooper Front page | perl.perl5.porters | Postings from November 2005

Re: XS-assisted SWASHGET (esp. for t/uni/class.t speedup)

Thread Previous | Thread Next
From:
Rafael Garcia-Suarez
Date:
November 30, 2005 06:58
Subject:
Re: XS-assisted SWASHGET (esp. for t/uni/class.t speedup)
Message ID:
20051130155752.257b3a42@grubert.mandrakesoft.com
SADAHIRO Tomoyuki wrote:
> Now a patch for the removal of subroutine SWASHGET is implemented.

> This patch will
> (1) remove lib/utf8_heavy.pl#utf8::SWASHGET,
> (2) move universal.c#XS_utf8_SWASHGET_heavy into utf8.c#S_swash_get,
> (3) patch up S_swash_get and Perl_swash_fetch,
> (4) remove codes for DEBUG information from S_swash_get,
> (5) add a line for S_swash_get to embed.fnc,
> (6) correct a line for S_utf8_common in embed.fnc ('s' vs 'p'), 
> (7) and modify some comments about SWASHGET in utf(8|ebcdic).h.

Thanks, applied as change 26229 to bleadperl.
I added a small cast to utf8.c to suppress a warning here :
        Perl_croak(aTHX_ "swash_get: unknown bits %"UVuf, (UV) bits);

BTW, would it be sensible to add one or several entries to
perldiag for the swash_get error messages ?

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About