develooper Front page | perl.perl5.porters | Postings from November 2005

Re: XS-assisted SWASHGET (esp. for t/uni/class.t speedup)=?iso-8859-1?q?=0A?=

Thread Next
From:
Tels
Date:
November 27, 2005 04:09
Subject:
Re: XS-assisted SWASHGET (esp. for t/uni/class.t speedup)=?iso-8859-1?q?=0A?=
Message ID:
200511271309.15339@bloodgate.com
-----BEGIN PGP SIGNED MESSAGE-----

Moin,

SADAHIRO Tomoyuki <bqw10602@nifty.com> wrote:

>>> >Parhaps SWASHGET may be able to recast as a C-level function
>> >rather than XS. For example,
>> 
>> I'd like to see that implemented. Cutting out one layer of subroutine 
>> indirection can't hurt :)
>
>Now a patch for the removal of subroutine SWASHGET is implemented.
>
>The patch gzipped (against perl patch 26206) is attached to this mail
>as swashget2.patch.gz

Cool.

>swashget2.patch.gz

Reading that, I wonder why the function(s) is(are) called swash_foo, but 
some comments and variables have "swa_tc_h" (e.g. "swatch") like in the 
following:

>+           swatch = swash_get(sv,
>+                   /* On EBCDIC & ~(0xA0-1) isn't a useful thing to do 
>*/
>+                               (klen) ? (code_point & ~(needents - 1)) : 
>0,
>+                               needents);

Should that read "swash = swash_get(..." for consistency? I'd expect that 
swash_get returns a "swash", not a "swatch" :)

Best wishes,

Tels

- -- 
 Signed on Sun Nov 27 13:06:30 2005 with key 0x93B84C15.
 Visit my photo gallery at http://bloodgate.com/photos/
 PGP key on http://bloodgate.com/tels.asc or per email.

 I'm a Sis-sis-sis-sis-sis-sis-sis-sinnahr...

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iQEVAwUBQ4mh6XcLPEOTuEwVAQEVoAf8C3Sh3gvkYgs76F4rZ32vlVeN8CY8EMHy
Ip6BEKOxDuS5wVgzQTG6r1kyrvw8p2hAO1JXiO0FnuUmk9yh0hsoN4OhS+mhVbfi
e/aMh5rN+XKuNenXvtMquTqfmR6eE8N4vDwynyBgTpDcWIFJRB8jNC3URpACZI54
fIOGlDLwxWFPDU2A1qfneXxxbxjL/TjL2syp2nczLfZpZl8AGUIdVU+ZoZPi6YQQ
z18XjezKKmhCgJaQ9OcrW/NztCEAmRKZSA8ysQ7aTeneNiz1/AJ9IGfokI4RvU1u
YIoTEpxUT7LAWPHN8+zCrftib0y+HG1dNtvg+34SHtgYYhIkusjGcg==
=oS59
-----END PGP SIGNATURE-----

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About