develooper Front page | perl.perl5.porters | Postings from November 2005

Re: [PATCH] sort/multicall patch

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
November 4, 2005 18:51
Subject:
Re: [PATCH] sort/multicall patch
Message ID:
20051105025208.GK3585@iabyn.com
On Sat, Oct 29, 2005 at 09:33:07PM +0100, Robin Houston wrote:
> This is the first "release candidate" of my sort/multicall patch.

Sorry, been too busy then too full of cold to look at this yet, and I kind
of have a responsibility since it was my mad suggestion in the first place
;-)

Looks like a nice piece of work. My only two comments are:

* should PUSH_MULTICALL take the CV as an arg rather than implicitly using
the cv variable?

* pp_sort() isn't using these macros. Will this change later, or are there
reasons why it can't?

-- 
"The greatest achievement of the Austrians has been convincing the world
that Hitler was German, and Mozart Austrian."

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About