develooper Front page | perl.perl5.porters | Postings from November 2005

Re: [PATCH] sort/multicall patch - cleanup f_sort.t failures

Thread Previous | Thread Next
From:
Jim Cromie
Date:
November 2, 2005 13:39
Subject:
Re: [PATCH] sort/multicall patch - cleanup f_sort.t failures
Message ID:
43693208.6040200@gmail.com
Rafael Garcia-Suarez wrote:

>Rafael Garcia-Suarez wrote:
>  
>
>>H.Merijn Brand wrote:
>>    
>>
>>>>This is the first "release candidate" of my sort/multicall patch.
>>>>        
>>>>
>>>Thanks, applied as change #25953.
>>>Lets see if it does not colour the smokes black
>>>      
>>>
>>Defaut config, with ithreads, on linux, at change 25955 :
>>
>>Failed Test                 Stat Wstat Total Fail  Failed  List of Failed
>>-------------------------------------------------------------------------------
>>../ext/B/t/concise-xs.t      255 65280   780    1   0.13%  781
>>../ext/B/t/f_sort.t                       20   13  65.00%  1-8 11-15
>>../ext/DB_File/t/db-btree.t    2   512   197  340 172.59%  28-197
>>op/sort.t                                141    2   1.42%  142
>>
>>There are obviously some test count changes to be done as well.
>>I'll look into it a bit.
>>    
>>
>
>I adapted the test count in concise-xs.t, and I just plainly removed the
>last test of op/sort.t (as change #25957). It was failing horribly
>both with and without threads, and moreover I'm not even sure we want
>to ensure that it's possible to wipe out the array currently being sorted.
>
>  
>
heres a patch which fixes those f_sort.t errs on   threads and 
non-threads for me.
I dunno why the /COMMON flag gets added, nor why it also affects B::Concise
renderings on non-threaded builds, but it appears real.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About