develooper Front page | perl.perl5.porters | Postings from August 2005

Re: [PATCH] Re: [perl #36667] Lengthy parameter passed to eval leads to bus error on FreeBSD 5.4

From:
Yitzchak Scott-Thoennes
Date:
August 8, 2005 09:42
Subject:
Re: [PATCH] Re: [perl #36667] Lengthy parameter passed to eval leads to bus error on FreeBSD 5.4
Message ID:
20050808164149.GA384@efn.org
On Fri, Aug 05, 2005 at 08:43:41AM +0200, Dominic Dunlop wrote:
> Pumpking(s), please don't apply my patch, as it may be unsafe despite  
> getting through the test suite:
> 
> On 2005?08?05, at 01:46, Dave Mitchell wrote:
> >
> >Perl_peep doesn't just do omptimisations; swome stuff is necessary for
> >normal running, eg
> >
> >    case OP_METHOD_NAMED:
> >        /* Relocate sv to the pad for thread safety.
> 
> I wondered about stuff like that, and thought I thrashed the patch  
> fairly hard on threading until nothing broke. Do you have time to  
> suggest a test or tests that will fail when such things are not done?
> 
> >... So peep recurses down the 'other' branch [of a conditional] to  
> >make sure it gets processed too.
> ...
> >The fix would probably be to temporary set the 'done' flag on the  
> >next op
> >before recursing. But I havn't got time to look into this yet.
> 
> Thanks for the insight. Time to delve into the code ...

FWIW, I thought making sure only optional stuff was in the optimizing
code was on Hugo's list of stuff wanted in 5.10.

Definitely worth pursuing.



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About