develooper Front page | perl.perl5.porters | Postings from August 2005

Re: [PATCH] Re: [perl #36667] Lengthy parameter passed to eval leads to bus error on FreeBSD 5.4

Thread Previous | Thread Next
From:
Dominic Dunlop
Date:
August 4, 2005 23:44
Subject:
Re: [PATCH] Re: [perl #36667] Lengthy parameter passed to eval leads to bus error on FreeBSD 5.4
Message ID:
34E84E80-0E2D-49BD-B61C-171A1A0DF9EE@mac.com
Pumpking(s), please don't apply my patch, as it may be unsafe despite  
getting through the test suite:

On 2005–08–05, at 01:46, Dave Mitchell wrote:
>
> Perl_peep doesn't just do omptimisations; swome stuff is necessary for
> normal running, eg
>
>     case OP_METHOD_NAMED:
>         /* Relocate sv to the pad for thread safety.

I wondered about stuff like that, and thought I thrashed the patch  
fairly hard on threading until nothing broke. Do you have time to  
suggest a test or tests that will fail when such things are not done?

> ... So peep recurses down the 'other' branch [of a conditional] to  
> make sure it gets processed too.
...
> The fix would probably be to temporary set the 'done' flag on the  
> next op
> before recursing. But I havn't got time to look into this yet.

Thanks for the insight. Time to delve into the code ...
-- 
Dominic Dunlop


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About