develooper Front page | perl.perl5.porters | Postings from July 2005

Re: [PATCH] Error in earlier patch in sv.c

Thread Previous
From:
H.Merijn Brand
Date:
July 13, 2005 09:55
Subject:
Re: [PATCH] Error in earlier patch in sv.c
Message ID:
20050713185706.23a919fd@pc09
On Wed, 13 Jul 2005 17:29:48 +0100, Robin Barker <Robin.Barker@npl.co.uk>
wrote:

> In an earlier patch of mine (18696), I made a mistake.
> 	[I added code to a one-line if statement 
> 	without changing it to a block if.]
> The attached patch fixes the mistake and (much harder) 
> provides a test to distinguish old and new behaviour.

Thanks, applied it as posted as change #25137

> Should new tests go at the end of the test file to
> preserve test numbers or with related tests?  I've
> put this test at the end but it really "belongs" 
> with the other tests of the form >%*2$...< >[12, 3]<

New tests go where they make most sense

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using Perl 5.6.2, 5.8.0, 5.8.5, & 5.9.2  on HP-UX 10.20, 11.00 & 11.11,
 AIX 4.3 & 5.2, SuSE 9.2 & 9.3, and Cygwin. http://www.cmve.net/~merijn
Smoking perl: http://www.test-smoke.org,    perl QA: http://qa.perl.org
 reports  to: smokers-reports@perl.org,                perl-qa@perl.org

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About