develooper Front page | perl.perl5.porters | Postings from December 2004

Re: [perl #33173] shellwords.pl and tainting

Thread Previous | Thread Next
From:
Alexey Tourbin
Date:
December 28, 2004 15:46
Subject:
Re: [perl #33173] shellwords.pl and tainting
Message ID:
20041228234544.GD7824@solemn.turbinal.org
On Tue, Dec 28, 2004 at 11:38:22AM -0800, chromatic wrote:
> On Tue, 2004-12-28 at 22:29 +0300, Alexey Tourbin wrote:
> 
> > --- perl-5.9.2.23688/lib/Text/ParseWords/taint.t-	2004-12-28 21:21:26 +0300
> > +++ perl-5.9.2.23688/lib/Text/ParseWords/taint.t	2004-12-28 21:39:56 +0300

[...]

> This being a module, it's okay to use at least test.pl here, if not
> Test::More.  It should have test comments either way.

lib/Text/ParseWords/taint.t was quickly made after lib/Text/ParseWords.t,
which does not use test.pl or Test::More, nor has it comments in ok/not ok
output.

(I placed it into separate file because it is impossible to enabled
taint mode in a Perl code.  BTW, could there be a better location for
lib/Text/ParseWords/taint.t?  I can add some more tests unrelated to
taint mode.  Maybe lib/Text/ParseWords.t should be relocated or split.)

Anyway, I can't see the reason for using Test::More offhand.
Having comments is nice, though.

> -- c

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About