develooper Front page | perl.perl5.porters | Postings from May 2004

Re: [PATCH] Re: [perl #29851] Problem with Carp and Safe

Thread Previous
From:
perl5-porters
Date:
May 31, 2004 08:21
Subject:
Re: [PATCH] Re: [perl #29851] Problem with Carp and Safe
Message ID:
c9fihl$v1r$1@post.home.lunix
In article <20040531152854.79_d0a3b@localhost>,
	Rafael Garcia-Suarez <rgarciasuarez@mandrakesoft.com> writes:
>  sub shortmess {	# Short-circuit &longmess if called via multiple packages
> -    { local $@; require Carp::Heavy; }	# XXX fix require to not clear $@?
> +    {
> +	local $@;
> +	# XXX fix require to not clear $@?
> +	require Carp::Heavy unless $INC{"Carp/Heavy.pm"};
> +    }

Please add a comment for that. A future casual reader of that code will be 
totally confused by the seemingly pointless unless.
Thread Previous

nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About