Re: my $x->{foo} doesn't work

Shinya Hayakawa <hayakawa@livedoor.jp> wrote:
:Thanks.
:I rewrote the patch as follows.
:
:--- pp_hot.c.orig       2004-05-21 10:49:37.000000000 +0900
:+++ pp_hot.c    2004-05-21 18:43:46.000000000 +0900
:@@ -204,7 +204,7 @@
:     if (PL_op->op_flags & OPf_MOD) {
:        if (PL_op->op_private & OPpLVAL_INTRO)
:            SAVECLEARSV(PAD_SVl(PL_op->op_targ));
:-        else if (PL_op->op_private & OPpDEREF) {
:+        if (PL_op->op_private & OPpDEREF) {
:            PUTBACK;
:            vivify_ref(PAD_SVl(PL_op->op_targ), PL_op->op_private & OPpDEREF);
:            SPAGAIN;

I have nothing in principle against including this, except that it is
missing tests. Perhaps you could have a go at adding some tests to
explore the edge cases around this - a good starting point, for example,
would be to find a test case that exposes the problem with your first
attempt at this patch.

Hugo

• my $x->{foo} doesn't work by tetryl
• Re: my $x->{foo} doesn't work by Rafael Garcia-Suarez
• ++(my $x = {}) [Was: Re: my $x->{foo} doesn't work] by Dan Kogai
• Re: ++(my $x = {}) [Was: Re: my $x->{foo} doesn't work] by Dan Kogai
• Re: ++(my $x = {}) [Was: Re: my $x->{foo} doesn't work] by Ronald J Kimball
• Re: ++(my $x = {}) [Was: Re: my $x->{foo} doesn't work] by Ronald J Kimball
• Re: ++(my $x = {}) [Was: Re: my $x->{foo} doesn't work] by Dan Kogai
• Re: my $x->{foo} doesn't work by Shinya Hayakawa
• Re: my $x->{foo} doesn't work by Elizabeth Mattijsen
• Re: my $x->{foo} doesn't work by Dave Mitchell
• Re: my $x->{foo} doesn't work by Rafael Garcia-Suarez
• Re: my $x->{foo} doesn't work by Dave Mitchell
• Re: my $x->{foo} doesn't work by Shinya Hayakawa
• Re: my $x->{foo} doesn't work by hv
• Re: my $x->{foo} doesn't work by Shinya Hayakawa
• Re: my $x->{foo} doesn't work by Dave Mitchell
• Re: my $x->{foo} doesn't work by Rafael Garcia-Suarez