Front page | perl.perl5.porters |
Postings from May 2004
mats@sm5sxl.net (via RT) wrote: > The '$header' variable in the parameter list at line 120 in > lib/h2xs.t is incorrectly placed (it should be the last one). It will > cause the h2xs test to fail as follows: ... > Below is a patch to fix it. I've applied your patches to the development version of perl, thanks (change #22828). What I don't explain, is, why does this test work for me ? I can see that h2xs uses Getopt::Long with the configuration option pass_through, so your patch looks fine, but it may only hide a deeper bug. > *** h2xs.t.orig Tue Aug 12 11:42:37 2003 > --- h2xs.t Sun May 16 15:13:38 2004 > *************** > *** 117,123 **** > Writing $name/MANIFEST > EONOXSFILES > > ! "-f -n $name $header -b $thisversion", $], <<"EOXSFILES", > Writing $name/ppport.h > Writing $name/lib/$name.pm > Writing $name/$name.xs > --- 117,123 ---- > Writing $name/MANIFEST > EONOXSFILES > > ! "-f -n $name -b $thisversion $header", $], <<"EOXSFILES", > Writing $name/ppport.h > Writing $name/lib/$name.pm > Writing $name/$name.xs