[perl #29624] Patch for h2xs.t in Perl 5.8.4

# New Ticket Created by  mats@sm5sxl.net 
# Please include the string:  [perl #29624]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org:80/rt3/Ticket/Display.html?id=29624 >



This is a bug report for perl from mats@sm5sxl.net,
generated with the help of perlbug 1.35 running under perl v5.8.4.


-----------------------------------------------------------------
[Please enter your report here]

The '$header' variable in the parameter list at line 120 in 
lib/h2xs.t is incorrectly placed (it should be the last one). It will
cause the h2xs test to fail as follows:

-----------------------------------------------------------------
not ok 95 - running /usr/local/src/perl-5.8.4/perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst h2xst.h -b 5.8.4 2>&1
#     Failed test (../lib/h2xs.t at line 169)
#          got: 'Defaulting to backwards compatibility with perl 5.8.4
# If you intend this module to be compatible with earlier perl versions, please
# specify a minimum perl version with the -b option.
# 
# Can't open h2xst/-b.h: No such file or directory
# '
#     expected: 'Writing h2xst/ppport.h
# Writing h2xst/lib/h2xst.pm
...
------------------------------------------------------------------

Below is a patch to fix it.

Mats Peterson <mats@sm5sxl.net>


----- cut here -----
*** h2xs.t.orig	Tue Aug 12 11:42:37 2003
--- h2xs.t	Sun May 16 15:13:38 2004
***************
*** 117,123 ****
  Writing $name/MANIFEST
  EONOXSFILES
  
! "-f -n $name $header -b $thisversion", $], <<"EOXSFILES",
  Writing $name/ppport.h
  Writing $name/lib/$name.pm
  Writing $name/$name.xs
--- 117,123 ----
  Writing $name/MANIFEST
  EONOXSFILES
  
! "-f -n $name -b $thisversion $header", $], <<"EOXSFILES",
  Writing $name/ppport.h
  Writing $name/lib/$name.pm
  Writing $name/$name.xs
----- cut here -----


[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
    category=install
    severity=high
---
Site configuration information for perl v5.8.4:

Configured by mats at Sun May 16 11:34:37 CEST 2004.

Summary of my perl5 (revision 5 version 8 subversion 4) configuration:
  Platform:
    osname=freebsd, osvers=4.6.2-release-p12, archname=i386-freebsd
    uname='freebsd pc10.snowbee.foo 4.6.2-release-p12 freebsd 4.6.2-release-p12 #0: sat nov 1 10:44:06 cet 2003 mats@pc10.snowbee.foo:usrobjusrsrcsyspc10 i386 '
    config_args='-Dprefix=/opt/perl -des'
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef use5005threads=undef useithreads=undef usemultiplicity=undef
    useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -I/usr/local/include',
    optimize='-O',
    cppflags='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -I/usr/local/include'
    ccversion='', gccversion='2.95.3 20010315 (release) [FreeBSD]', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags ='-Wl,-E  -L/usr/local/lib'
    libpth=/usr/lib /usr/local/lib
    libs=-lm -lcrypt -lutil -lc
    perllibs=-lm -lcrypt -lutil -lc
    libc=, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' '
    cccdlflags='-DPIC -fPIC', lddlflags='-shared  -L/usr/local/lib'

Locally applied patches:
    

---
@INC for perl v5.8.4:
    /usr/home/mats/lib/perl
    /opt/perl/lib/5.8.4/i386-freebsd
    /opt/perl/lib/5.8.4
    /opt/perl/lib/site_perl/5.8.4/i386-freebsd
    /opt/perl/lib/site_perl/5.8.4
    /opt/perl/lib/site_perl
    .

---
Environment for perl v5.8.4:
    HOME=/root
    LANG=sv_SE.ISO_8859-1
    LANGUAGE (unset)
    LC_COLLATE=C
    LC_MESSAGES=C
    LC_TIME=C
    LD_LIBRARY_PATH=/usr/home/mats/lib:/usr/local/netpbm/lib
    LOGDIR (unset)
    PATH=/opt/perl/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/usr/X11R6/bin:/usr/local/mysql/bin:/usr/local/apache/bin:/usr/local/j2sdk/bin:/usr/local/netpbm/bin:/usr/local/imagick/bin:/usr/home/mats/bin:/usr/home/mats/scripts:/root/scripts:/root/bin
    PERLLIB=/usr/home/mats/lib/perl
    PERL_BADLANG (unset)
    SHELL=/bin/csh

• [perl #29624] Patch for h2xs.t in Perl 5.8.4 by mats @ sm5sxl . net