develooper Front page | perl.perl5.porters | Postings from April 2004

Re: FileCache 1.03 (as per 5.8.3) breaks system()

Thread Previous | Thread Next
From:
Rafael Garcia-Suarez
Date:
April 19, 2004 06:21
Subject:
Re: FileCache 1.03 (as per 5.8.3) breaks system()
Message ID:
20040419151832.25f5b57f@localhost
Rafael Garcia-Suarez wrote:
> Jerrad Pierce wrote:
> > Okay, the fixed packagae is at ftp://pthbb.org/pub/pm/FileCache/1.04.tgz
> > 
> > The diff is
> > 
> > =begin
> > --- FileCache.pm	Sun Jun 22 13:44:26 2003
> > +++ FileCache-1.04/FileCache.pm	Fri Apr 16 14:49:05 2004
> 
> Thanks, applied to bleadperl as change #22715.

Now looking at it again, I didn't update the tests : I will do it, but I've
a couple of questions.

First, the changes seem to be all like this :

--- 01open.t    (revision 3463)
+++ 01open.t    (working copy)
@@ -2,7 +2,7 @@
 use FileCache;
 use vars qw(@files);
 BEGIN {
-    @files = qw(foo bar baz quux Foo_Bar);
+    @files = qw(foo bar baz quux Foo'Bar);
     chdir 't' if -d 't';
  
     #For tests within the perl distribution
@@ -10,7 +10,7 @@
     END;
 }
 END{
-  1 while unlink @files;
+  unlink @files;
 }
  
and I don't understand why it's necessary--in fact it looks like there have
been change in bleadperl and not in your copy:

Change 20175 by merijn@merijn-l1 on 2003/07/21 14:26:43
 
        Subject: Re: [PATCH] test clean-up for VMS
        From: "Craig A. Berry" <craigberry@mac.com>
        Date: Sun, 20 Jul 2003 10:43:32 -0500
        Message-ID: <3F1AB8A4.2070207@mac.com>

Change 19839 by jhi@kosh on 2003/06/22 16:31:05
 
        Subject: FileCache 1.03 broken on VMS -- possible patch
        From: "Craig A. Berry" <craigberry@mac.com>
        Date: Sat, 21 Jun 2003 10:31:59 -0500
        Message-ID: <3EF47A6F.9060904@mac.com>

Secondly, there are new test files, and one of those (07pipe.t) has a todo-test
that succeeds at least on my machine : shouldn't it be un-marked as todo ?

Thirdly, there is garbage in the output of 06system.t, and while "make test_harness"
can grok it, "make test", which is less tolerant, reports a failing test. This
should be fixed.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About