develooper Front page | perl.perl5.porters | Postings from April 2004

Re: FileCache 1.03 (as per 5.8.3) breaks system()

Thread Previous | Thread Next
From:
Tim Jenness
Date:
April 17, 2004 12:11
Subject:
Re: FileCache 1.03 (as per 5.8.3) breaks system()
Message ID:
Pine.LNX.4.58.0404170820410.1933@yncnxv
On Fri, 16 Apr 2004, Jerrad Pierce wrote:

> Okay, the fixed packagae is at ftp://pthbb.org/pub/pm/FileCache/1.04.tgz
> 
> =begin
> --- FileCache.pm	Sun Jun 22 13:44:26 2003
> +++ FileCache-1.04/FileCache.pm	Fri Apr 16 14:49:05 2004
> @@ -88,11 +91,6 @@
>      *{$pkg.'::cacheout'} = \&cacheout;
>      *{$pkg.'::close'}    = \&cacheout_close;
>  
> -    # Reap our children
> -    ${"$pkg\::SIG"}{'CLD'}  = 'IGNORE' if $Config{sig_name} =~ /\bCLD\b/;
> -    ${"$pkg\::SIG"}{'CHLD'} = 'IGNORE' if $Config{sig_name} =~ /\bCHLD\b/;
> -    ${"$pkg\::SIG"}{'PIPE'} = 'IGNORE' if $Config{sig_name} =~ /\bPIPE\b/;
> -
>      # Truth is okay here because setting maxopen to 0 would be bad
>      return $cacheout_maxopen = $args{maxopen} if $args{maxopen};
>      foreach my $param ( '/usr/include/sys/param.h' ){
> @@ -113,6 +111,11 @@
>  
>  # Open in their package.
>  sub cacheout_open {
> +  # Reap our children
> +  local $SIG{CLD}  ||= 'IGNORE'if $Config{sig_name} =~ /\bCHLD\b/;
> +  local $SIG{CHLD} ||= 'IGNORE'if $Config{sig_name} =~ /\bCLD\b/;
> +  local $SIG{PIPE} ||= 'IGNORE'if $Config{sig_name} =~ /\bPIPE\b/;
> +

Without looking at the context, this doesn't seem correct since CLD is 
being equated with CHLD and vice versa.

-- 
Tim Jenness
JAC software
http://www.jach.hawaii.edu/~timj


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About