develooper Front page | perl.perl5.porters | Postings from March 2004

Re: [PATCH] Move Win32.pm/Win32.xs from libwin32 module to core Perl

From:
Nicholas Clark
Date:
March 19, 2004 04:21
Subject:
Re: [PATCH] Move Win32.pm/Win32.xs from libwin32 module to core Perl
Message ID:
20040319122129.GO701@plum.flirble.org
On Thu, Mar 18, 2004 at 01:13:49PM -0800, Jan Dubois wrote:

> Ok, I've finally remembered to do this.  In addition to the patches included
> below, the following files need to be *added*:
> 
>   win32/ext/Win32/Makefile.PL
>   win32/ext/Win32/Win32.pm
>   win32/ext/Win32/Win32.xs
> 
> They are all included in the attached tarball.  Please also *delete* the file
> 
>   lib/Win32.pod
> 
> The documentation is now included in Win32.pm.
> 
> The included Win32 module also contains the new Win32::IsAdmin() function
> supplied by Steve Hay.

Thanks

On Fri, Mar 19, 2004 at 10:33:17AM +0000, Steve Hay wrote:
> Jan Dubois wrote:
> 
> >>I can look into moving Win32.pm/Win32.xs (but nothing else) into the core.
> >>    
> >>
> >Ok, I've finally remembered to do this.
> >
> Brilliant.  It's great to have the core Win32 / libwin32 overlap mess 
> cleared up at long last.
> 
> The patch works fine for me on WinXP / MSVC++ (with both nmake and dmake).
> 
> A note to whoever applies this stuff: don't forget to add a new line to 
> the Extensions_realclean sections in win32/Makefile and 
> win32/makefile.mk as well (see below).  Jan's patch was evidently 
> prepared before those new sections were added.

Thanks. I probably wouldn't have realised this unless you had mentioned it.

All applied as 22537. I hope I didn't mess up.
 
Nicholas Clark



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About