develooper Front page | perl.perl5.porters | Postings from February 2004

[PATCH] nmake distclean cleans too much from lib/Digest on Win32

Thread Next
Steve Hay
February 27, 2004 09:39
[PATCH] nmake distclean cleans too much from lib/Digest on Win32
Message ID:
I've been investigating some problems that I'm currently experiencing 
with Test-Smoke on Win32, and I've found that "nmake distclean" (which 
Test-Smoke runs between smokes) is deleting too much.

A fresh Perl (5.8 or 5.9) source tree contains


When you build it, lib/Digest/ gets created.

When you distclean it, the *whole* of lib/Digest gets nuked:

    if exist ..\lib\Digest rmdir /s /q ..\lib\Digest
    if exist ..\lib\Digest rmdir /s ..\lib\Digest

Now when you try to rebuild that source tree (like Test-Smoke does) you 
get errors about "prerequisite Digest::base not found", and the tests 
being missing.

The attached patch removes the nuking of the lib/Digest directory.  The 
lib/Digest/ file that was created during the build is explicitly 
deleted earlier in the Makefile anyway, so that'll still be deleted (as 
it should).

Was there any particular reason that the whole of lib/Digest was being 
nuked?  I can't see any.  It used to be an OK thing to do, I guess, but 
now that lib/Digest contains and the tests (changes 21807 and 
21809) I think the rmdir should go.

The patch needs to be applied to perl-5.8 as well as perl-current.

I've no idea if other platforms have the same issue or not.  Maybe they 
do since Makefile.SH contains:

    -rmdir lib/B lib/Data lib/Digest

in its "_cleaner2" target.  (It doesn't seem to explicitly delete 
lib/Digest/, though.)  Perhaps someone with access to other 
platforms could investigate?

- Steve

Radan Computational Ltd.

The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only.  If you have received this message in error or there are any problems, please notify the sender immediately.  The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden.  Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd.  The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.

Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About