develooper Front page | perl.perl5.porters | Postings from January 2004

Storable's hints file shouldn't blanket set optimize to -O2 on Linux

Thread Next
From:
Nicholas Clark
Date:
January 29, 2004 04:38
Subject:
Storable's hints file shouldn't blanket set optimize to -O2 on Linux
Message ID:
20040127230209.GA85547@plum.flirble.org
IIRC there was a thread at some point questioning Storable's behaviour
on Linux w.r.t. optimiser flags. It seems that Storable has always been
forcing -O2, come what may. I've committed the following, which does
something more sane: drop -O3 to -O2 on gcc on Linux.

Nicholas Clark

Change 22238 by nicholas@faith on 2004/01/27 21:51:27

	Storable's hints file shouldn't blanket set optimize to -O2 on Linux
	Only *drop* optimize to -O2 if it's -O3 on gcc on Linux

Affected files ...

... //depot/perl/ext/Storable/hints/linux.pl#4 edit

Differences ...

==== //depot/perl/ext/Storable/hints/linux.pl#4 (text) ====
Index: perl/ext/Storable/hints/linux.pl
--- perl/ext/Storable/hints/linux.pl#3~20861~	Sat Aug 23 23:13:13 2003
+++ perl/ext/Storable/hints/linux.pl	Tue Jan 27 13:51:27 2004
@@ -6,5 +6,10 @@
 # 20011002 and 3.3, and in Redhat 7.1 with gcc 3.3.1. The failures
 # happen only for unthreaded builds, threaded builds work okay.
 use Config;
-$self->{OPTIMIZE} = '-O2';
+if ($Config{gccversion}) {
+    my $optimize = $Config{optimize};
+    if ($optimize =~ s/(^| )-O3( |$)/$1-O2$2/) {
+	$self->{OPTIMIZE} = $optimize;
+    }
+}
 
End of Patch.

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About