[perl #25157] [PATCH] Text-Balanced extract_quotelike fails on certain delims in HERE docs

# New Ticket Created by  David Manura 
# Please include the string:  [perl #25157]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=25157 >


This is a bug report for perl from davidm.perl@math2.org,
generated with the help of perlbug 1.34 running under perl v5.8.3.


-----------------------------------------------------------------
[Please enter your report here]

The following patch corrects an error in Text::Balanced, in extract_quotelike,
where HERE documents are not recognized if certain characters are present
in the HERE document delimiters.  For example,

   <<"*";\n\n*\n;

The problem is that $label was not escaped with \Q ... \E in the regexes.

The patch also includes a new test case that fails under the original code.

======================
diff -r -u perl-5.8.3/lib/Text/Balanced/t/extqlk.t perl-5.8.3-patched/lib/Text/Balanced/t/extqlk.t
--- perl-5.8.3/lib/Text/Balanced/t/extqlk.t	2001-11-19 22:59:36.000000000 -0500
+++ perl-5.8.3-patched/lib/Text/Balanced/t/extqlk.t	2004-01-20 01:26:56.000000000 -0500
@@ -14,7 +14,7 @@
  # Change 1..1 below to 1..last_test_to_print .
  # (It may become useful if the test is moved to ./t subdirectory.)

-BEGIN { $| = 1; print "1..89\n"; }
+BEGIN { $| = 1; print "1..91\n"; }
  END {print "not ok 1\n" unless $loaded;}
  use Text::Balanced qw ( extract_quotelike );
  $loaded = 1;
@@ -81,6 +81,7 @@
  <<"   EOHERE"; done() \nline1\nline2\n   EOHERE\nand next
  <<""; done()\nline1\nline2\n\n and next
  <<; done()\nline1\nline2\n\n and next
+<<"*";\n\n*\n;


  "this is a nested $var[$x] {";
diff -r -u perl-5.8.3/lib/Text/Balanced.pm perl-5.8.3-patched/lib/Text/Balanced.pm
--- perl-5.8.3/lib/Text/Balanced.pm	2003-07-04 10:33:00.000000000 -0400
+++ perl-5.8.3-patched/lib/Text/Balanced.pm	2004-01-20 01:28:04.000000000 -0500
@@ -749,7 +749,7 @@
  		my $extrapos = pos($$textref);
  		$$textref =~ m{.*\n}gc;
  		$str1pos = pos($$textref);
-		unless ($$textref =~ m{.*?\n(?=$label\n)}gc) {
+		unless ($$textref =~ m{.*?\n(?=\Q$label\E\n)}gc) {
  			_failmsg qq{Missing here doc terminator ('$label') after "} .
  				     substr($$textref, $startpos, 20) .
  				     q{..."},
@@ -758,7 +758,7 @@
  			return;
  		}
  		$rd1pos = pos($$textref);
-		$$textref =~ m{$label\n}gc;
+		$$textref =~ m{\Q$label\E\n}gc;
  		$ld2pos = pos($$textref);
  		return (
  			$startpos,	$oppos-$startpos,	# PREFIX
======================

[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
     category=library
     severity=medium
---
Site configuration information for perl v5.8.3:

Configured by dmanura at Mon Jan 19 21:39:59 2004.

Summary of my perl5 (revision 5 version 8 subversion 3) configuration:
   Platform:
     osname=MSWin32, osvers=4.0, archname=MSWin32-x86-multi-thread
     uname=''
     config_args='undef'
     hint=recommended, useposix=true, d_sigaction=undef
     usethreads=undef use5005threads=undef useithreads=define usemultiplicity=define
     useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
     use64bitint=undef use64bitall=undef uselongdouble=undef
     usemymalloc=n, bincompat5005=undef
   Compiler:
     cc='cl', ccflags ='-nologo -Gf -W3 -MD -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT  -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -DPERL_MSVCRT_READFIX',
     optimize='-MD -DNDEBUG -O1',
     cppflags='-DWIN32'
     ccversion='', gccversion='', gccosandvers=''
     intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
     d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10
     ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', lseeksize=8
     alignbytes=8, prototype=define
   Linker and Libraries:
     ld='link', ldflags ='-nologo -nodefaultlib -release  -libpath:"c:\perl\lib\CORE"  -machine:x86'
     libpth=D:\lib\mvs-6.0\VC98\lib
     libs=  oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib msvcrt.lib
     perllibs=  oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib msvcrt.lib
     libc=msvcrt.lib, so=dll, useshrplib=yes, libperl=perl58.lib
     gnulibc_version='undef'
   Dynamic Linking:
     dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
     cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -release  -libpath:"c:\perl\lib\CORE"  -machine:x86'

Locally applied patches:


---
@INC for perl v5.8.3:
     d:/testing/perl-5.8.3/lib
     .

---
Environment for perl v5.8.3:
     HOME=
     LANG (unset)
     LANGUAGE (unset)
     LD_LIBRARY_PATH (unset)
     LOGDIR (unset)
     PATH=
     PERLDB_OPTS=RemotePort=127.0.0.1:2000
     PERL_BADLANG (unset)
     SHELL (unset)

• [perl #25157] [PATCH] Text-Balanced extract_quotelike fails on certain delims in HERE docs by David Manura
• Re: [perl #25157] [PATCH] Text-Balanced extract_quotelike fails on certain delims in HERE docs by Dave Mitchell
• Re: [perl #25157] [PATCH] Text-Balanced extract_quotelike fails on certain delims in HERE docs by David Manura