develooper Front page | perl.perl5.porters | Postings from December 2003

Re: Change 22021: Upgrade to Test::Harness 2.40.

Thread Next
From:
Rafael Garcia-Suarez
Date:
December 31, 2003 01:37
Subject:
Re: Change 22021: Upgrade to Test::Harness 2.40.
Message ID:
20031231103219.53902986.rgarciasuarez@free.fr
Rafael Garcia-Suarez wrote:
>
> Change 22021 by rgs@sixop on 2003/12/31 08:28:43
> 
> 	Upgrade to Test::Harness 2.40.
[...]
> ==== //depot/perl/lib/Test/Harness/t/00compile.t#3 (text) ====
> Index: perl/lib/Test/Harness/t/00compile.t
> --- perl/lib/Test/Harness/t/00compile.t#2~21826~	Sun Nov 30 12:31:59 2003
> +++ perl/lib/Test/Harness/t/00compile.t	Wed Dec 31 00:28:43 2003
> @@ -13,6 +13,7 @@
>  use Test::More tests => 5;
>  
>  BEGIN { use_ok 'Test::Harness' }
> +BEGIN { diag( "Testing Test::Harness $Test::Harness::VERSION" ) }
>  
>  BEGIN { use_ok 'Test::Harness::Straps' }

I don't get the rationale for this change; diag() is supposed to be
used for error/diagnostic messages, right ? not for comments, more
mundane in nature. (This perturbs the nice line-up of my test logs.
And I like when things are nicely lined up. See :)

    $ ./perl TEST ../lib/Test/Harness/t/00compile.t 
    t/../lib/Test/Harness/t/00compile....# Testing Test::Harness 2.40
    ok
    All tests successful.
    u=0.08  s=0  cu=0.24  cs=0.01  scripts=1  tests=5

I suggest to s/diag\( "/print\( "# / here.

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About