develooper Front page | perl.perl5.porters | Postings from November 2003

Re: Cwd.xs: off-by-one buffer overflow in realpath()

Thread Previous
From:
Enache Adrian
Date:
November 4, 2003 13:02
Subject:
Re: Cwd.xs: off-by-one buffer overflow in realpath()
Message ID:
20031104220328.GA1784@ratsnest.hole
On Mon, Nov 03, 2003 a.d., Rafael Garcia-Suarez wrote:
> Gisle Aas wrote:
> > 
> > It is probably a good idea to keep in sync the the BSD source code so
> > applying the same patch as they did is the right thing.  If you want
> > nitpicking I would say you should break the line after '>' like they
> > did:
> > 
> > ftp://ftp.freebsd.org/pub/FreeBSD/CERT/patches/SA-03:08/realpath.patch

They actually replaced that old realpath() with a new, threadsafe
implementation in -CURRENT.
Unfortunately, I have no time now to look into integrating it --
but that may be a good idea (the new realpath looks much cleaner and
doesn't use chdir).

Regards,
Adi

> 
> In fact it's probably a good idea to have an eye on the BSD source code.
> Doesn't File::Glob use the BSD shell glob routines internally ? Anyone
> has links one could watch semi-automatically ?

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About