develooper Front page | perl.perl5.porters | Postings from November 2003

Re: Cwd.xs: off-by-one buffer overflow in realpath()

Thread Previous | Thread Next
From:
Rafael Garcia-Suarez
Date:
November 3, 2003 13:29
Subject:
Re: Cwd.xs: off-by-one buffer overflow in realpath()
Message ID:
20031103223508.23f8327d.rgarciasuarez@free.fr
H.Merijn Brand wrote:
> On Mon 03 Nov 2003 22:24, Rafael Garcia-Suarez <rgarciasuarez@free.fr> wrote:
> > Casey West wrote:
> > > ftp://ftp.freebsd.org/pub/FreeBSD/CERT/advisories/FreeBSD-SA-03:08.realpath.asc 
> > 
> > Thanks, applied as #21646 to blead. (by hand, for some reason.)
> > 
> > > --- perl-current-orig/ext/Cwd/Cwd.xs    Thu May 16 18:16:19 2002
> > > +++ perl-current/ext/Cwd/Cwd.xs Thu Oct 30 12:08:12 2003
> > > @@ -166,7 +166,7 @@
> > >                 rootd = 0;
> > >  
> > >         if (*wbuf) {
> > > -               if (strlen(resolved) + strlen(wbuf) + rootd + 1 > MAXPATHLEN) {
> > > +               if (strlen(resolved) + strlen(wbuf) + (1-rootd) + 1 > MAXPATHLEN) {
> 
> This correct? 1 *-* rootd
> This is completely different from off-by-one, as the subject says

Looks correct to me. rootd is 0 or 1 depending on whether the path
represents the root directory ("/\0") or not.
Thread Previous | Thread Next

nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About