develooper Front page | perl.perl5.porters | Postings from November 2003

Re: [PATCH] Re: MinGW-3.1.0-1 _CRTIMP definition preempting win32.h's

Thread Previous | Thread Next
From:
Abe Timmerman
Date:
November 2, 2003 06:54
Subject:
Re: [PATCH] Re: MinGW-3.1.0-1 _CRTIMP definition preempting win32.h's
Message ID:
200311021551.15678.abe@ztreet.demon.nl
Op een wisselvallige herfstdag (Sunday 02 November 2003 15:09), schreef Rafael 
Garcia-Suarez:

> So a simple patch like this one should solve the problem. Does it look
> good ? (sorry, I can't test it, no MinGW here)
>
> Index: win32/win32.h
> ===================================================================
> --- win32/win32.h	(revision 2678)
> +++ win32/win32.h	(working copy)
> @@ -465,7 +465,7 @@
>  #ifdef PERL_CORE
>
>  /* C doesn't like repeat struct definitions */
> -#ifndef _CRTIMP
> +#if !defined(_CRTIMP) || (defined(__MINGW32__) &&
> (__MINGW32_MAJOR_VERSION>=3)) #define _CRTIMP __declspec(dllimport)
>  #endif
>
> End of Patch.

applied on 21466 (blead), that seems to make it build (tests still running)

As Jan D. notices it is rather loud (the redefine warnings).

I'll try a tiny smoke with this patch later on...


Good luck,

Abe
-- 
Adding a -w warning for the "pseudohashes are going away, repent and
give away your all wordly possessions" to 5.8.1 is okay, but what I
don't understand is why Sarathy is thinking people would be using -w
that much more than they would be reading the 5.8.0 announcement? :-)
                                   -- Jarkko Hietaniemi on p5p @ 2002-09-06


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About