develooper Front page | perl.perl5.porters | Postings from October 2003

Re: [PATCH] Update Digest-MD5

Thread Previous | Thread Next
From:
Gisle Aas
Date:
October 15, 2003 03:05
Subject:
Re: [PATCH] Update Digest-MD5
Message ID:
lrfzhux1e1.fsf@caliper.activestate.com
And the following patch brings Digest-MD5 in sync with the last CPAN version.

diff -ru perl-current/ext/Digest/MD5/Changes perl-hack/ext/Digest/MD5/Changes
--- perl-current/ext/Digest/MD5/Changes	Tue Aug  5 06:57:08 2003
+++ perl-hack/ext/Digest/MD5/Changes	Wed Oct 15 03:02:10 2003
@@ -1,3 +1,28 @@
+2003-10-09   Gisle Aas <gisle@ActiveState.com>
+
+   Release 2.30
+
+   Some tweaks to make the module build on perl-5.004 and
+   perl-5.005 again.
+
+
+
+2003-10-06   Gisle Aas <gisle@ActiveState.com>
+
+   Release 2.29
+
+   Another try.  Forgot to update the test checksums.
+
+
+
+2003-10-06   Gisle Aas <gisle@ActiveState.com>
+
+   Release 2.28
+
+   Fix minor documentation typo.
+
+
+
 2003-08-04   Gisle Aas <gisle@ActiveState.com>
 
    Release 2.27
@@ -131,7 +156,7 @@
    Release 2.16
 
    Sync up with the bleadperl version:
-      - use SvPVbyte() if avaiable
+      - use SvPVbyte() if available
       - fixes to make the code 'gcc -Wall'-clean
 
 
@@ -140,7 +165,7 @@
 
    Release 2.15
 
-   Avoid exit() in Makefile.PL and bleedperls redefinition of printf
+   Avoid exit() in Makefile.PL and bleadperl redefinition of printf
    in the alignment test program.
    Patch by Doug MacEachern <dougm@covalent.net>.
 
@@ -157,7 +182,7 @@
    Document the missing padding for the base64 digests.
 
    If both XS bootstrap and locating Digest::Perl::MD5 fails
-   reraise the original XS bootstrap exception.
+   re-raise the original XS bootstrap exception.
 
 
 
@@ -400,7 +425,7 @@
    $md5->digest will automatically reset now.
 
    Digest::HMAC methods add() and addfile() did not return the
-   corret object.
+   correct object.
 
    Added Digest.pm loading module.  I am not sure this is a good idea.
 
@@ -543,7 +568,7 @@
 routines is limited to (2^32 - 1) bytes -- that's 4 gigabytes. I'm
 sorry if that's a real problem for you ...
 
-And finally, a minor complilation warning (unsigned char * used with
+And finally, a minor compilation warning (unsigned char * used with
 function having char * prototype) has also been eliminated.
 
 *** 96/04/09 Version 1.6
@@ -565,7 +590,7 @@
 *** 96/03/12 Version 1.5.2
 
 Minor fixes from Christopher J Madsen <madsen@computek.net> to provide
-support for building on OS/2 (and to work arround a perl -w bug).
+support for building on OS/2 (and to work around a perl -w bug).
 
 Remove warning about possible difference between add('foo', 'bar') and
 add('foobar'). This is not true (it may have been true in the earliest
diff -ru perl-current/ext/Digest/MD5/MD5.pm perl-hack/ext/Digest/MD5/MD5.pm
--- perl-current/ext/Digest/MD5/MD5.pm	Tue Aug  5 06:57:08 2003
+++ perl-hack/ext/Digest/MD5/MD5.pm	Wed Oct 15 03:02:10 2003
@@ -3,7 +3,7 @@
 use strict;
 use vars qw($VERSION @ISA @EXPORT_OK);
 
-$VERSION = '2.27';  # $Date: 2003/08/05 06:08:10 $
+$VERSION = '2.30';  # $Date: 2003/10/09 09:26:59 $
 
 require Exporter;
 *import = \&Exporter::import;
@@ -104,7 +104,7 @@
 Note that the base64 encoded string returned is not padded to be a
 multiple of 4 bytes long.  If you want interoperability with other
 base64 encoded md5 digests you might want to append the redundant
-string redundant "==" to the result.
+string "==" to the result.
 
 =back
 
@@ -247,7 +247,7 @@
     close(FILE);
     print $md5->b64digest, " $file\n";
 
-Or we can use the builtin addfile method for more efficient reading of
+Or we can use the addfile method for more efficient reading of
 the file:
 
     use Digest::MD5;
diff -ru perl-current/ext/Digest/MD5/Makefile.PL perl-hack/ext/Digest/MD5/Makefile.PL
--- perl-current/ext/Digest/MD5/Makefile.PL	Sat Feb 15 01:52:59 2003
+++ perl-hack/ext/Digest/MD5/Makefile.PL	Wed Oct 15 03:02:36 2003
@@ -24,7 +24,6 @@
     @extra,
     'dist'         => { COMPRESS => 'gzip -9f', SUFFIX => 'gz', },
 );
-exit;
 
 
 
diff -ru perl-current/ext/Digest/MD5/t/align.t perl-hack/ext/Digest/MD5/t/align.t
--- perl-current/ext/Digest/MD5/t/align.t	Thu Jan 16 13:05:32 2003
+++ perl-hack/ext/Digest/MD5/t/align.t	Wed Oct 15 03:02:10 2003
@@ -13,7 +13,7 @@
 use Digest::MD5 qw(md5_hex);
 
 my $str = "\100" x 20;
-substr($str, 0, 1, "");  # chopping off first char makes the string unaligned
+substr($str, 0, 1) = "";  # chopping off first char makes the string unaligned
 
 #use Devel::Peek; Dump($str); 
 
diff -ru perl-current/ext/Digest/MD5/t/files.t perl-hack/ext/Digest/MD5/t/files.t
--- perl-current/ext/Digest/MD5/t/files.t	Tue Aug  5 06:57:08 2003
+++ perl-hack/ext/Digest/MD5/t/files.t	Wed Oct 15 03:02:10 2003
@@ -20,26 +20,26 @@
 my $EXPECT;
 if (ord "A" == 193) { # EBCDIC
     $EXPECT = <<EOT;
-4553104c3c951d43043b3520388b8a1e  Changes
+e1d7df564fad76d2f0ed628c648d5833  Changes
 0565ec21b15c0f23f4c51fb327c8926d  README
-36dc7eba19a0fea92baf68bec5adc56a  MD5.pm
+4d48606863dbc7fd131c2e7b5eefc8c5  MD5.pm
 45e5e6785b47fb922f33b4a74c29a148  MD5.xs
 276da0aa4e9a08b7fe09430c9c5690aa  rfc1321.txt
 EOT
 } elsif ("\n" eq "\015") { # MacOS
     $EXPECT = <<EOT;
-9ffb101ffaa83f2d04bc5cea6ee0bfb4  Changes
+c780484c87b64e32bd55c6be58b623b4  Changes
 6c950a0211a5a28f023bb482037698cd  README
-188b5ab345169e90094165dd32dd7f6b  MD5.pm
+546c4e62999c9888d7d46732a21c9dff  MD5.pm
 ca3f8cb317c5d088ed9f97204c6b8cda  MD5.xs
 754b9db19f79dbc4992f7166eb0f37ce  rfc1321.txt
 EOT
 } else {
     # This is the output of: 'md5sum Changes README MD5.pm MD5.xs rfc1321.txt'
     $EXPECT = <<EOT;
-6b0b5e6be6ee9dbbfbb1d77f9a82a87f  Changes
+2bdd59aa1e816cd8df05968e70f75cf1  Changes
 6c950a0211a5a28f023bb482037698cd  README
-188b5ab345169e90094165dd32dd7f6b  MD5.pm
+546c4e62999c9888d7d46732a21c9dff  MD5.pm
 ca3f8cb317c5d088ed9f97204c6b8cda  MD5.xs
 754b9db19f79dbc4992f7166eb0f37ce  rfc1321.txt
 EOT
diff -ru perl-current/ext/Digest/MD5/t/utf8.t perl-hack/ext/Digest/MD5/t/utf8.t
--- perl-current/ext/Digest/MD5/t/utf8.t	Fri May  3 08:00:55 2002
+++ perl-hack/ext/Digest/MD5/t/utf8.t	Wed Oct 15 03:02:10 2003
@@ -1,8 +1,10 @@
 #!perl -w
 
-if ($] < 5.006) {
-    print "1..0\n";
-    exit;
+BEGIN {
+    if ($] < 5.006) {
+	print "1..0 # Skipped: your perl don't know unicode\n";
+	exit;
+    }
 }
 
 print "1..3\n";

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About