Front page | perl.perl5.porters |
Postings from October 2003
Rafael Garcia-Suarez <rgarciasuarez@free.fr> writes:
> void
> -pack_sockaddr_un(pathname)
> - char * pathname
> +pack_sockaddr_un(pathname_sv)
> + SV * pathname_sv
> CODE:
This change make the function usage message uglier:
$ perl -MSocket -e 'pack_sockaddr_un()'
Usage: Socket::pack_sockaddr_un(pathname_sv) at -e line 1.
I would suggest you instead name the other variable 'pathname_pv'.
> {
> #ifdef I_SYS_UN
> struct sockaddr_un sun_ad; /* fear using sun */
> STRLEN len;
> + char * pathname;
>
> Zero( &sun_ad, sizeof sun_ad, char );
> sun_ad.sun_family = AF_UNIX;
> - len = strlen(pathname);
> + pathname = SvPV(pathname_sv,len);
Thread Previous
|
Thread Next