develooper Front page | perl.perl5.porters | Postings from September 2003

Re: Storable difference between perl-5.8.1 and Storable-2.08

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
September 27, 2003 12:15
Subject:
Re: Storable difference between perl-5.8.1 and Storable-2.08
Message ID:
20030927201537.T30881@plum.flirble.org
On Sat, Sep 27, 2003 at 07:44:19PM +0200, Rolf Petter Halle wrote:
> It looks to me as the Storable.xs file that ships with the 5.8.1
> distributions differs a tiny bit from the one that ships with
> Storable-2.08 from CPAN.

Thanks. Well spotted.

> The 5.8.1 version seems correct, but I guess you might want to update
> the code in Storable-2.08 unless it is already done.

It's not possible to upload the same tar file twice to PAUSE.
It would be possible either to upload a Storable-2.08.01-tar.gz with
this fix, or a full blown 2.09

> *** perl-5.8.1/ext/Storable/Storable.xs Mon Sep  8 16:05:27 2003
> --- Storable-2.08/Storable.xs   Fri Sep  5 20:42:41 2003
> ***************
> *** 784,788 ****
>   #endif /* (PATCHLEVEL <= 6) */
>   
> ! #if (PATCHLEVEL < 8 || (PATCHLEVEL == 8 && SUBVERSION < 1))
>   #define PL_sv_placeholder PL_sv_undef
>   #endif
> --- 784,788 ----
>   #endif /* (PATCHLEVEL <= 6) */
>   
> ! #if (PATCHLEVEL <= 8 || (PATCHLEVEL == 8 && SUBVERSION < 1))
>   #define PL_sv_placeholder PL_sv_undef
>   #endif

I thought that this would have no effect, but I'm slightly wrong.
The code on CPAN is fine with every perl version *except* 5.8.1
(and future 5.8.x)

If the code on CPAN built with 5.8.1 it fails t/restrict.t:

t/restrict.......FAILED tests 1, 5, 9, 13
        Failed 4/16 tests, 75.00% okay


Given that 5.8.1 already ships with this version of Storable, it's going
to take either a manual build or considerable bypassing of CPAN.pm to
get 5.8.1 to build something it knows it already has.

Offhand I can't think of any features to add to Storable to justify
a 2.09 release. [A cheating way to cover up this bug :-) ]

> Thanks for all the work you do. Couldn't live without Perl.

Thanks for the feedback. It's nice to know that people like perl.

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About