develooper Front page | perl.perl5.porters | Postings from September 2003

[PATCH 5.8.1 @21211] magic.t

Thread Next
From:
Ilya Zakharevich
Date:
September 16, 2003 19:18
Subject:
[PATCH 5.8.1 @21211] magic.t
Message ID:
20030917021757.GA20261@math.berkeley.edu
This patch marks the only test which reproducibly fails on OS/2 as 'TODO'.

--- ./t/op/magic.t-pre	Mon Aug 25 03:22:48 2003
+++ ./t/op/magic.t	Tue Sep 16 18:39:28 2003
@@ -125,7 +125,8 @@ END
 END
     close CMDPIPE;
     $? >>= 8 if $^O eq 'VMS'; # POSIX status hiding in 2nd byte
-    print $? & 0xFF ? "ok 6\n" : "not ok 6\n";
+    my $todo = ($^O eq 'os2' ? ' # TODO: EMX v0.9d_fix4 bug: wrong nibble? ' : '');
+    print $? & 0xFF ? "ok 6$todo\n" : "not ok 6$todo\n";
 
     $test += 4;
 }

This test assumes that Test::Harness bug I mentioned in my preceeding
message is fixed (otherwise it succeeds in `make test', but not in
`make test_harness').

Yours,
Ilya

P.S. Some remarks about problematic behaviour of Test::Harness:

   a) I see the diagnostic

	op/magic....ok
             6/53 skipped: various reasons

      Some time ago it was (the way I wrote it ;-)

        op/magic....ok        6/53 skipped: various reasons

      The current form wastes the screen real estate for no apparent
      reason.  Why?

   b) In the summary above I see no mention of the fact that one test
      is marked as TODO.  Test::Harness documentation mentions that
      TODO items are `as good as maintaining a programmatic TODO
      list'.  But what good it is if I can't find what in the list?

Puzzled,
Ilya

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About