develooper Front page | perl.perl5.porters | Postings from September 2003

RE: perl562@20985 [PATCH MakeMaker]

Thread Next
From:
Orton, Yves
Date:
September 8, 2003 05:00
Subject:
RE: perl562@20985 [PATCH MakeMaker]
Message ID:
71B318898201D311845C0008C75DAD1C08961178@defra1ex2
> > Patch as follows

Er, sorry about the mangled patch. Luckily it isnt that hard to fix by hand.

:-)

> > --- ExtUtils-MakeMaker-6.16/lib/ExtUtils/Install.pm     2003-06-05
> > 10:04:31.000000000 +0200
> > +++ ExtUtils-MakeMaker-6.16-pathced/lib/ExtUtils/Install.pm 
>     2003-09-08
> > 11:58:26.000000000 +0200
> > @@ -15 +15 @@
> > -my $splitchar = $^O eq 'VMS' ? '|' : ($^O eq 'os2' || $^O 
> eq 'dos') ? ';' :
> > ':';
> > +my $splitchar = $^O eq 'VMS' ? '|' : 
> $^O=~/^(?:os2|dos|MSWin32)$/ ? ';' :
> 
> You might want to add epoc and netware in there
> (have we a dictionary of known $^O values somewhere ?)

The best dictionary of known $^O values that I know of is in File::Spec.
Which is why I argue that a method to do multiple directory splitting should
be implemented there.  One issue with however is a name for the method.
Obviously splitpath is taken. Maybe split_search_path() would be a good
choice?

> > ':';
> > 
> > Although I do not understand why you go through this 
> contortion when there
> > is $Config{path_sep} available for use. 
> 
> me too ;-)
> Sounds like a better solution. Perhaps is it not backward-compatible
> enough ?

Dunno. I think its moot if Ken implements this in File::Spec.  He can use
$Config{path_sep} if its robust enough, otherwise he can code it as needed
for each class.  I put together a patch for File::Spec to add a pathsep()
and started on split_search_path() patch for  File::Spec, but its on my home
machine, and I didnt want to pursue it without some discussion.

cheers
Yves




Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About