develooper Front page | perl.perl5.porters | Postings from August 2003

Re: [PATCH] File::Spec::Win32

From:
Tels
Date:
August 18, 2003 14:38
Subject:
Re: [PATCH] File::Spec::Win32
Message ID:
200308182338.54596@bloodgate.com
-----BEGIN PGP SIGNED MESSAGE-----

Moin,

On Monday 18 August 2003 23:21, Ken Williams wrote:
> On Monday, August 18, 2003, at 04:13  PM, Tels wrote:
> > The patch in question is 20746, by yours truly, and can be viewed here:
> > @@ -657,7 +656,7 @@
> >
> >      # Figure out the effective $base and clean it up.
> >      if ( !defined( $base ) || $base eq '' ) {
> > - -	$base = cwd();
> > +	$base = $self->cwd();
> >      }
>
> In general this is the right way to go - much better to provide a
> consistent cwd() method than to use various piecemeal code to get it.
>
> I'm doing a little cwd-oriented cleanup of the File::Spec::* stuff in
> maintperl, will have patch shortly.

I meant, that probably this change "broke" something. Because if you call

	$self->cwd();

then the first argument to cwd is $self, vs:

	cwd();

where there are no arguments. However, without looking in the code, I don't 
know whether this makes a difference or not.

You might also look into my orginal mails:

	http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2003-07/msg00366.html
	http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2003-07/msg00362.html

Best wishes,

Tels

Btw: Regarding the Ownership of File::Spec: 

	I, for one, welcome our new File::Spec Overlord!

:-)


- -- 
 Signed on Mon Aug 18 23:31:14 2003 with key 0x93B84C15.
 PGP key on http://bloodgate.com/tels.asc or per email.

 "Not King yet."

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)
Comment: When cryptography is outlawed, bayl bhgynjf jvyy unir cevinpl.

iQEVAwUBP0FHbXcLPEOTuEwVAQGa3gf9EgzofLcBwETmhzQaJ73jiIOWsIkyBDKx
MZJmCaxNl/7ZyuSrkTvT8IR0oH/k3ArkggVYCpp2lmHwqRP7IcUhGrdjfEIyHZAF
mUQshpuzDLWz3rLv37mKwdN1BBfhHwknGrH8U/dLaz2IUefHNW8TG/bd4aUTsHms
TTkvv+WvEumXNK5CU7ah7cnyEK+hxwk6EGe1FCg/62f4bg3omnADPuNdgz+jECbO
UfnGmJ8Qv+W0sE78r8LAXeTpBG5hjnRhPS6N61eea1mCDy4w+ArxGuHdJkhQqCBV
CZT2OiIpoAhPnTdszXD4xzSsRvOqrlIMzGbSJU+kVXMbcPoKGv/XVQ==
=y5gU
-----END PGP SIGNATURE-----




nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About