develooper Front page | perl.perl5.porters | Postings from August 2003

Re: [PATCH] File::Spec::Win32

From:
Ken Williams
Date:
August 18, 2003 14:21
Subject:
Re: [PATCH] File::Spec::Win32
Message ID:
E9FBF734-D1C1-11D7-84BF-003065F6D85A@mathforum.org

On Monday, August 18, 2003, at 04:13  PM, Tels wrote:
>
> The patch in question is 20746, by yours truly, and can be viewed here:
>
> 	http://public.activestate.com/cgi-bin/perlbrowse?patch=20746

Thanks.

> Here is a chunk that looks suspicious to me:
>
> @@ -657,7 +656,7 @@
>
>      # Figure out the effective $base and clean it up.
>      if ( !defined( $base ) || $base eq '' ) {
> - -	$base = cwd();
> +	$base = $self->cwd();
>      }

In general this is the right way to go - much better to provide a 
consistent cwd() method than to use various piecemeal code to get it.

I'm doing a little cwd-oriented cleanup of the File::Spec::* stuff in 
maintperl, will have patch shortly.

  -Ken




nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About