develooper Front page | perl.perl5.porters | Postings from August 2003

Re: [PATCH] File::Spec::Win32

Thread Previous | Thread Next
From:
Tels
Date:
August 18, 2003 14:12
Subject:
Re: [PATCH] File::Spec::Win32
Message ID:
200308182313.05738@bloodgate.com
-----BEGIN PGP SIGNED MESSAGE-----

Moin,

>On Monday, August 18, 2003, at 07:16  AM, Mattia Barbon wrote:
>
>>   Hello,
>> this is the version in maintperl (File::Spec::Win32 version = 1.4,
>> File::Spec version = 0.86), and it's currently broken, because it 
>> calls a ->cwd method on itself, which isn't present. Patch adds the method 
>> (back?).
>>   Alternatives are renaming the method to _cwd (since it's not 
>> documented) or rewrite the code to explicitly do the require (as in 
>> File::Spec::Unix).

>Hi Mattia,
>
>Looks like a big File::Spec patch got into maintperl without me 
>noticing it.  Thanks for letting me know.

The patch in question is 20746, by yours truly, and can be viewed here:

	http://public.activestate.com/cgi-bin/perlbrowse?patch=20746

I forgot to track this patch, and only saw it again when Jarkko suddely 
applied it :)

>I'm a little confused, because File::Spec::Win32 inherits from 
>File::Spec::Unix, which provides a cwd() method.  Are you sure you're 
>seeing the problem correctly?  I also added a regression test that 
>makes sure that File::Spec::Win32->can('cwd'), and it passes.

Here is a chunk that looks suspicious to me:

@@ -657,7 +656,7 @@
 
     # Figure out the effective $base and clean it up.
     if ( !defined( $base ) || $base eq '' ) {
- -	$base = cwd();
+	$base = $self->cwd();
     }


maybe this was wrong? I am not sure, it is too late, and I should be already 
snoring...

Best wishes,

Tels

- -- 
 Signed on Mon Aug 18 23:13:03 2003 with key 0x93B84C15.
 PGP key on http://bloodgate.com/tels.asc or per email.

 "I am soo clumsy today." *crash*

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)
Comment: When cryptography is outlawed, bayl bhgynjf jvyy unir cevinpl.

iQEVAwUBP0FBYHcLPEOTuEwVAQG3dwf6A7UPJQw/Sh6DwuP1sWVxO++tqzh8fl2f
6azNz699HQenpiJffEf5jzRXE8tPdrH031qw5NPF4+v/dNC0Dq0k1J6sPkXBQSYf
ErFkNCi5bcGqPG8M8NPKt28tpP90rNU7588nUbRpKh0tbhABTxb4Yqqgbd2AIYOk
Iz1HI0ihXMgDbxqHZLIS/G1kKjgMozbbaoUrpm6BwkA8nZ6x2xUz3QMFc+jZEo9b
nRrdxDHPYQdELB4rL45uc0HIUXRlkMluXWoUhm1VK8ibLmf9ZTTtcfBQwHNcWfHy
skc7jnsVvn1hqA3noiS45UXVf/d/n7mVRnxeYJd43G0Phwof2pGhDA==
=F3Fz
-----END PGP SIGNATURE-----


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About