develooper Front page | perl.perl5.porters | Postings from August 2003

Re: Storable Error

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
August 11, 2003 16:00
Subject:
Re: Storable Error
Message ID:
20030811235955.S20130@plum.flirble.org
On Mon, Aug 11, 2003 at 11:00:54PM +0100, Nicholas Clark wrote:

> All hash element assignments seem to go through pp_helem which uses
> hv_fetch to do the store. And as you've patched both hv_fetch variants it
> all works.
> 
> I *think* that anonymous hash creation and whole hash assignment should
> go via hv_store, but I'm unable to make an example which triggers it.

Baths are good. I sat in the bath and had inspiration. There is no bug there.

hv_store_ent already has this code to turn on HASKFLAGS:

    if (is_utf8) { 
        key = (char*)bytes_from_utf8((U8*)key, &klen, &is_utf8); 
        if (is_utf8) 
            flags = HVhek_UTF8; 
        if (key != keysave) 
            flags |= HVhek_WASUTF8 | HVhek_FREEKEY; 
        HvHASKFLAGS_on((SV*)hv); 
    } 

hv_store_flags has this code:

    if (flags) 
        HvHASKFLAGS_on((SV*)hv); 

I believe Abhijit found all the bugs.

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About